Macros are one of those things that one person really can't tell another person how to do it. How my macros are arranged and exactly how I situate them isn't going to be the same as someone else necessarily, and really, as long as they work appropriately, there's no "wrong" way to do them. Some people use ways to extend macros beyond what is available in the game, through things such as Windower scripts or Spellcast, while others use more traditional means and potentially rely on multiple macros to swap in gear for a single specific function.
Where you place your spells, weaponskills, job abilities, gear swaps, etc on your macro lists are entirely up to you.
I'll just list what I personally do for macroing to give you an idea of something you may want to do.
For weaponskills and TP gear, I am not one of those individuals that has the weaponskill gear in the same macro(s) as the actual weaponskill. I'll have the weaponskill macro off to the side away from everything else, so that if for some reason, as I'm swapping into my WS gear, something happens to where I may want to not weaponskill (the mob has moved, it has changed to a stance to where it absorbs physical damage, etc), I can hold back until I'm sure I want to weaponskill when I do.
For job abilities and spells, I never keep multiple ones in the same macro either, so that if I want one job ability, I don't have to necessarily use another to get to that one. For job abilities that have gear that enhances/augments it (and is a relevant effect) or gear with other stats that modify it (such as +VIT for Rampart) I'll macro that in to equip when I use the job ability to gain the boost. Same goes for spells, though I try to start with some amount of Fast Cast as well to make sure the spell gets off quicker.
My thoughts and reviews
Lady Jinte wrote:
Vlorsutes' Negotiation Skill rises 0.2 points
Vlorsutes' Observant Parent Skill rises 0.3 points
Vlorsutes' Argument Diffusing Skill rises 0.1 points
on all sorts of sci-fi stuff...and things.